-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding uni v4 to dex.trades #7543
Conversation
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One possible way of implementation
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/base/platforms/uniswap_v4_base_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/macros/models/_project/uniswap_compatible_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/base/platforms/uniswap_v4_base_base_trades.sql
Outdated
Show resolved
Hide resolved
Adding a record here for chains that are missing ❌Arbitrum |
fwiw, i think you should leave the logic and just pass in where applicable. you can also change edit: to be clear, that's for follow up PRs when decoding is cleaned up (if it is at all) |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
Adding uniswap v4 to dex.trades on base
quick links for more information: