Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Raydium's CP-Swap (CPMM) to DEX table #7549

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

JacobSharples
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 25, 2025 13:51
@github-actions github-actions bot added WIP work in progress dbt: solana covers the Solana dbt subproject labels Jan 25, 2025
@JacobSharples JacobSharples marked this pull request as ready for review January 25, 2025 17:06
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 25, 2025
@jeff-dude jeff-dude requested a review from Hosuke January 27, 2025 15:53
@jeff-dude
Copy link
Member

jeff-dude commented Jan 27, 2025

@Hosuke can you ensure this is built out in the same design as v4 here, and then give general review?

we likely also need to add to base union downstream to include in final table.

edit: that will likely cause CI to fail on timeout, as we run more models and heavy solana data. can always filter as needed to see it run.

scratch that, i will review now

@jeff-dude jeff-dude assigned jeff-dude and unassigned Hosuke Jan 28, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 28, 2025
@@ -14,6 +14,7 @@
{% set solana_dexes = [
ref('raydium_v3_base_trades')
, ref('raydium_v4_base_trades')
, ref('raydium_v5_base_trades')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @JacobSharples we needed to add to this downstream model to then appear in dex_solana.trades 🙏

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, thank you for adding

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Jan 28, 2025
@jeff-dude
Copy link
Member

canceling the full history run, as we have commits that show it ran + did a test run on small subset of data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: solana covers the Solana dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants