Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoW Protocol] Add addresses for ApeOut 1inch solver #7598

Merged
merged 3 commits into from
Feb 3, 2025
Merged

[CoW Protocol] Add addresses for ApeOut 1inch solver #7598

merged 3 commits into from
Feb 3, 2025

Conversation

bram-vdberg
Copy link
Contributor

Description:

This PR adds the barn and production addresses for the ApeOut 1inch solver on Gnosis chain.

@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Jan 30, 2025
@jeff-dude jeff-dude marked this pull request as ready for review January 30, 2025 16:14
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 30, 2025
@jeff-dude
Copy link
Member

jeff-dude commented Jan 30, 2025 •
edited
Loading

please use this PR for the opportunity to add unique tests to your solver spells (across all chains applicable). you will apply test here, for example on gnosis. you can search the repo for usage of data_tests and unique or unique_combination_of_columns if multiple columns necessary to test. this will help avoid your incident from last addition.

@jeff-dude jeff-dude self-assigned this Jan 30, 2025
@jeff-dude jeff-dude marked this pull request as draft January 30, 2025 16:16
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Jan 30, 2025
@bram-vdberg bram-vdberg marked this pull request as ready for review February 3, 2025 08:13
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 3, 2025
jeff-dude
jeff-dude approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you add solvers to more chains, plz be sure to add uniqueness test there as well

@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Feb 3, 2025
@jeff-dude jeff-dude merged commit 0561f69 into duneanalytics:main Feb 3, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: hourly covers the hourly dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bram-vdberg @jeff-dude