Move to TLS client protocol for http connections #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I need to rebase but we can start the discussion. |
AaronAtDuo
commented
Jan 25, 2023
| if cert_file: | ||
| context.load_cert_chain(cert_file, key_file) | ||
| if ca_certs: | ||
| context.verify_mode = ssl.CERT_REQUIRED | ||
| context.load_verify_locations(cafile=ca_certs) | ||
| else: | ||
| # Can't check hostnames if we're not requiring server certificates | ||
| context.check_hostname = False |
There was a problem hiding this comment.
PROTOCOL_TLS_CLIENT automatically makes check_hostname True (side note, that means PROTOCOL_SSLv23 and PROTOCOL_TLS don't?) but if we don't require certs, we obviously can't required hostname checking.
|
This would change the default behavior to start enforcing hostname verification when certificates are in use. Is that a concern? |
|
yeah it is. We have a number of tests that disable cert validation |
and those are exactly the tests that failed until I added the line about disabling hostname verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TLS_PROTOCOL is itself deprecated, this is the suggested update. It does technically change the default behavior though:
https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS_CLIENT