chore: update_integration() function parameter clarification. Closes #280 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add policy_key parameter add deprecation warning for visual_style parameter Tested-by: manual testing
MarkTripod-Duo
changed the title
AaronAtDuo
reviewed
Nov 12, 2024
duo_client/admin.py
Outdated
| @@ -2792,15 +2792,15 @@ def update_integration(self, | |||
| trusted_device_days=None, | |||
| ip_whitelist=None, | |||
| ip_whitelist_enroll_policy=None, | |||
| groups_allowed=None, | |||
| groups_allowed=None, policy_key=None, | |||
There was a problem hiding this comment.
can we split this into two lines, to be consistent with the surroundings?
AaronAtDuo
reviewed
Nov 12, 2024
| @@ -2838,6 +2840,8 @@ def update_integration(self, | |||
| if name is not None: | |||
| params['name'] = name | |||
| if visual_style is not None: | |||
| warnings.warn("The 'visual_style' argument is deprecated. May be removed in a future release.", | |||
There was a problem hiding this comment.
do we do this other places, for deprecated parameters?
There was a problem hiding this comment.
Yes. In get_authentication_log() and get_group()
Updated parameter definition indentation to match previous iteration for consistency.
MarkTripod-Duo
commented
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add policy_key parameter
add deprecation warning for visual_style parameter
Tested-by: manual testing
Description
Added a deprecation warning to the 'visual_style' argument processing. Added new parameter for 'policy_key' to support setting of application level custom policy value.
Motivation and Context
Changes are made to bring client closer to available Admin API endpoint functionality.
How Has This Been Tested?
Tested manually on a local virtual environment.
Types of Changes