Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: change archive transformer #3490

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

Neotamandua
Copy link
Member

@Neotamandua Neotamandua commented Feb 12, 2025

Resolves #3494

@Neotamandua Neotamandua force-pushed the neotamandua/change_transformer branch from f64bc10 to cee95a5 Compare February 13, 2025 10:07
@Neotamandua Neotamandua marked this pull request as ready for review February 13, 2025 10:07
@Neotamandua Neotamandua force-pushed the neotamandua/change_transformer branch 3 times, most recently from cad73f8 to dd86024 Compare February 13, 2025 15:36
@Neotamandua Neotamandua force-pushed the neotamandua/change_transformer branch from dd86024 to 8f00490 Compare February 13, 2025 15:45
herr-seppia
herr-seppia previously approved these changes Feb 13, 2025
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Remove short-circuiting in transformer
- Add prevention of any double flow insertion for transformer
- Change internal struct names to avoid ambiguity between a transaction and a transfer
- Add missing account inflow case (CONTRACT_TO_ACCOUNT)
- Refactor transformer code
- Update comments
- Update CHANGELOG
@Neotamandua Neotamandua merged commit b7d58f8 into master Feb 13, 2025
16 checks passed
@Neotamandua Neotamandua deleted the neotamandua/change_transformer branch February 13, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node: add recording of contract_to_account moonlight inflows to archive
2 participants