Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jira): support vault id #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Djiit
Copy link
Contributor

@Djiit Djiit commented Oct 29, 2024

  • feat(jira): support vaultid
  • fix(jira): add missing dependency in package.json

@Djiit Djiit changed the title jira support vault id feat(jira): support vault id Oct 29, 2024
@@ -235,7 +248,7 @@ function formatDescription(
): string {
return (
description?.content
.map((c) => c.content.map((cc) => cc.text).join(""))
.map((c) => c.content?.map((cc) => cc.text).join(""))
Copy link
Contributor Author

@Djiit Djiit Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of our tickets had objects like type: rule in it, without any content.

@Djiit Djiit marked this pull request as ready for review October 29, 2024 15:19
Comment on lines 27 to +28

const missingEnvVars = requiredEnvVars.filter(varName => !process.env[varName]);
const missingEnvVars = requiredEnvVars.filter(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line formatting seems off. The lambda function should be on the same line as the filter method for better readability.

Comment on lines 13 to +28
const DUST_API_KEY = process.env.DUST_API_KEY;
const DUST_WORKSPACE_ID = process.env.DUST_WORKSPACE_ID;
const DUST_VAULT_ID = process.env.DUST_VAULT_ID;
const DUST_DATASOURCE_ID = process.env.DUST_DATASOURCE_ID;

const requiredEnvVars = [
'JIRA_SUBDOMAIN',
'JIRA_EMAIL',
'JIRA_API_TOKEN',
'DUST_API_KEY',
'DUST_WORKSPACE_ID',
'DUST_DATASOURCE_ID'
"JIRA_SUBDOMAIN",
"JIRA_EMAIL",
"JIRA_API_TOKEN",
"DUST_API_KEY",
"DUST_WORKSPACE_ID",
"DUST_VAULT_ID",
"DUST_DATASOURCE_ID",
];

const missingEnvVars = requiredEnvVars.filter(varName => !process.env[varName]);
const missingEnvVars = requiredEnvVars.filter(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure consistent use of single quotes for strings to adhere to coding standards. Change instances of double quotes to single quotes.

];

const missingEnvVars = requiredEnvVars.filter(varName => !process.env[varName]);
const missingEnvVars = requiredEnvVars.filter(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line formatting seems off. The lambda function should be on the same line as the filter method for better readability.

];

const missingEnvVars = requiredEnvVars.filter(varName => !process.env[varName]);
const missingEnvVars = requiredEnvVars.filter(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure consistent use of single quotes for strings to adhere to coding standards. Change instances of double quotes to single quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant