Various nits (#8478)

* Fix Create DataSource link * fix top k * close the DataSourcePicker modal when data source is selected * remove claude-instant-1.2 (deprecated tomorrow) * switch to count tokens to test anthropic API key * fix import
dust-tt · Nov 6, 2024 · 2aef97f · 2aef97f
1 parent b481411
commit 2aef97f
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 19 deletions.
diff --git a/front/components/app/blocks/DataSource.tsx b/front/components/app/blocks/DataSource.tsx
@@ -227,7 +227,7 @@ export default function DataSource({
               <input
                 type="text"
                 className={classNames(
-                  "block w-8 flex-1 rounded-md px-1 py-1 text-sm font-normal",
+                  "block w-12 flex-1 rounded-md px-1 py-1 text-sm font-normal",
                   readOnly
                     ? "border-white ring-0 focus:border-white focus:ring-0"
                     : "border-white focus:border-gray-300 focus:ring-0"

diff --git a/front/components/data_source/DataSourcePicker.tsx b/front/components/data_source/DataSourcePicker.tsx
@@ -5,7 +5,6 @@ import {
   PopoverTrigger,
   ScrollArea,
   Searchbar,
-  Separator,
 } from "@dust-tt/sparkle";
 import type {
   DataSourceViewType,
@@ -103,6 +102,8 @@ export default function DataSourcePicker({
     setFilteredDataSourceViews(newDataSources.slice(0, 30));
   }, [spaceDataSourceViews, searchFilter]);
 
+  const [open, setOpen] = useState(false);
+
   return (
     <div className="flex items-center">
       <div className="flex items-center">
@@ -117,7 +118,7 @@ export default function DataSourcePicker({
             "No DataSource"
           )
         ) : (
-          <PopoverRoot>
+          <PopoverRoot open={open} onOpenChange={setOpen}>
             <PopoverTrigger>
               {selectedDataSourceView ? (
                 <div
@@ -138,7 +139,7 @@ export default function DataSourcePicker({
                 <Button variant="outline" label="Select DataSource" isSelect />
               ) : (
                 <Link
-                  href={`/w/${owner.sId}/data-sources/spaces`}
+                  href={`/w/${owner.sId}/spaces/${space.sId}`}
                   className={classNames(
                     readOnly ? "text-gray-300" : "text-gray-700"
                   )}
@@ -169,12 +170,12 @@ export default function DataSourcePicker({
                           },
                         ]);
                         setSearchFilter("");
+                        setOpen(false);
                       }}
                     >
                       <div className="my-1">
                         <div className="text-sm">{dsv.dataSource.name}</div>
                       </div>
-                      <Separator />
                     </div>
                   ))}
                   {filteredDataSourceViews.length === 0 && (

diff --git a/front/pages/api/w/[wId]/providers/[pId]/check.ts b/front/pages/api/w/[wId]/providers/[pId]/check.ts
@@ -95,34 +95,39 @@ async function handler(
           return;
 
         case "anthropic":
-          const testGenerate = await fetch(
-            "https://api.anthropic.com/v1/complete",
+          const testCountTokens = await fetch(
+            "https://api.anthropic.com/v1/messages/count_tokens",
             {
               method: "POST",
               headers: {
                 "x-api-key": config.api_key,
                 "anthropic-version": "2023-06-01",
+                "anthropic-beta": "token-counting-2024-11-01",
                 "Content-Type": "application/json",
               },
               body: JSON.stringify({
-                prompt: "\n\nHuman: 👋\n\nAssistant:",
-                model: "claude-instant-1.2",
-                max_tokens_to_sample: 1,
-                stop_sequences: [],
+                model: "claude-3-5-sonnet-20241022",
+                system: "You are a scientist",
+                messages: [
+                  {
+                    role: "user",
+                    content: "Hello, Claude",
+                  },
+                ],
               }),
             }
           );
 
-          if (!testGenerate.ok) {
-            const errRes = await testGenerate.json();
+          if (!testCountTokens.ok) {
+            const errRes = await testCountTokens.json();
             const errType = errRes.error?.type ?? "unknown error";
             const errMessage =
               errRes.error?.message ?? "contact us at [email protected]";
             res
               .status(400)
               .json({ ok: false, error: `[${errType}] ${errMessage}` });
           } else {
-            await testGenerate.json();
+            await testCountTokens.json();
             res.status(200).json({ ok: true });
           }
           return;

diff --git a/front/pages/api/w/[wId]/providers/[pId]/models.ts b/front/pages/api/w/[wId]/providers/[pId]/models.ts
@@ -176,7 +176,6 @@ async function handler(
           } else {
             if (chat) {
               anthropic_models = [
-                { id: "claude-instant-1.2" },
                 { id: "claude-2.1" },
                 { id: "claude-3-haiku-20240307" },
                 { id: "claude-3-sonnet-20240229" },
@@ -186,10 +185,7 @@ async function handler(
                 { id: "claude-3-opus-20240229" },
               ];
             } else {
-              anthropic_models = [
-                { id: "claude-instant-1.2" },
-                { id: "claude-2.1" },
-              ];
+              anthropic_models = [{ id: "claude-2.1" }];
             }
           }