Skip to content

Commit

Permalink
[Table upsert] Bump max col name length to 1024 (#9039)
Browse files Browse the repository at this point in the history
Description
---
Length at 512 contributes to bursts of errors, see e.g. [here]()

Name > 512 chars is likely 95% of the time caused by a
bad (unparseable) csv

Moving to 1024 chars: the idea is to go from 95% to 99.9% and reduce
monitor noise

Risks
---
na

Deploy
---
front
  • Loading branch information
philipperolet authored Dec 1, 2024
1 parent 8c9a9b2 commit 546cbd6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion front/lib/api/tables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import logger from "@app/logger/logger";
import type { DataSourceResource } from "../resources/data_source_resource";

const MAX_TABLE_COLUMNS = 512;
const MAX_COLUMN_NAME_LENGTH = 512;
const MAX_COLUMN_NAME_LENGTH = 1024;

type CsvParsingError = {
type:
Expand Down

0 comments on commit 546cbd6

Please sign in to comment.