Feedback migration (#9396)

* Added changes to models from the feedback loop PR * Added conversationShared column to feedbacks table * Enforcing non null values for feedback * Removed unused Non-attributes of AgentMessageFeedback * Undoing manual changes, preparing migration * Adding sqlize instructions * Added migration via npm run create-db-migration * Conversation explicitly not shared by default * Anticipating migration file conflict, renamed variable * Using agentMessage to stick to User convention just above * removed non-migration code * updated name in migration --------- Co-authored-by: Lucas <[email protected]>
dust-tt · Dec 17, 2024 · 625a9c4 · 625a9c4
1 parent ec60d8a
commit 625a9c4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/front/lib/api/assistant/feedback.ts b/front/lib/api/assistant/feedback.ts
@@ -175,6 +175,7 @@ export async function createOrUpdateMessageFeedback(
       userId: user.id,
       thumbDirection,
       content,
+      isConversationShared: false,
     });
     return newFeedback !== null;
   }

diff --git a/front/lib/models/assistant/conversation.ts b/front/lib/models/assistant/conversation.ts
@@ -300,6 +300,7 @@ export class AgentMessageFeedback extends BaseModel<AgentMessageFeedback> {
   declare agentConfigurationVersion: number;
   declare agentMessageId: ForeignKey<AgentMessage["id"]>;
   declare userId: ForeignKey<UserModel["id"]>;
+  declare isConversationShared: boolean;
 
   declare thumbDirection: AgentMessageFeedbackDirection;
   declare content: string | null;
@@ -333,6 +334,11 @@ AgentMessageFeedback.init(
       type: DataTypes.TEXT,
       allowNull: true,
     },
+    isConversationShared: {
+      type: DataTypes.BOOLEAN,
+      allowNull: false,
+      defaultValue: false,
+    },
   },
   {
     modelName: "agent_message_feedback",

diff --git a/front/migrations/db/migration_132.sql b/front/migrations/db/migration_132.sql
@@ -0,0 +1,2 @@
+-- Migration created on Dec 16, 2024
+ALTER TABLE "public"."agent_message_feedbacks" ADD COLUMN "isConversationShared" BOOLEAN NOT NULL DEFAULT false;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- Migration created on Dec 16, 2024
		ALTER TABLE "public"."agent_message_feedbacks" ADD COLUMN "isConversationShared" BOOLEAN NOT NULL DEFAULT false;