[connectors] Fix(Zendesk) - users not found (#8912)

* fix: fix issues with users not found by the SDK * fix: ignore issues with users not found by the SDK * 🔊
dust-tt · Nov 26, 2024 · 635eafc · 635eafc
1 parent e762f86
commit 635eafc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/connectors/src/connectors/zendesk/lib/sync_ticket.ts b/connectors/src/connectors/zendesk/lib/sync_ticket.ts
@@ -175,7 +175,16 @@ ${metadata}
 Conversation:
 ${comments
   .map((comment) => {
-    const author = users.find((user) => user.id === comment.author_id);
+    let author;
+    try {
+      author = users.find((user) => user.id === comment.author_id);
+    } catch (e) {
+      logger.warn(
+        { connectorId, e, ...loggerArgs },
+        "[Zendesk] Error finding the author of a comment."
+      );
+      author = null;
+    }
     return `
 [${new Date(Number(comment?.created_at)).toISOString()}] ${
       author ? `${author.name} (${author.email})` : "Unknown User"

diff --git a/connectors/src/connectors/zendesk/temporal/activities.ts b/connectors/src/connectors/zendesk/temporal/activities.ts
@@ -433,7 +433,7 @@ export async function syncZendeskTicketBatchActivity({
     return { hasMore: false, nextLink: "" };
   }
 
-  const users = await zendeskApiClient.users.list();
+  const users = (await zendeskApiClient.users.list()) || [];
 
   const comments = await concurrentExecutor(
     tickets,