[front] Keep space reoslution for legacy endpoints (#9758)

front/lib/api/resource_wrappers.ts

@@ -247,19 +247,43 @@ function withDataSourceFromRoute<T, A extends SessionOrKeyAuthType>(
 
       const dataSource = await DataSourceResource.fetchById(auth, dsId);
 
-      const { space } = resources;
-      if (!space) {
+      const shouldKeepLegacyEndpointSupport =
+        sessionOrKeyAuth === null || sessionOrKeyAuth instanceof Authenticator;
+
+      if (!dataSource) {
         return apiError(req, res, {
-          status_code: 400,
+          status_code: 404,
           api_error: {
-            type: "invalid_request_error",
-            message: "Invalid space id.",
+            type: "data_source_not_found",
+            message: "The data source you requested was not found.",
           },
         });
       }
 
+      let { space } = resources;
+
+      if (!space) {
+        if (shouldKeepLegacyEndpointSupport) {
+          if (auth.isSystemKey()) {
+            // We also handle the legacy usage of connectors that taps into connected data sources which
+            // are not in the global space. If this is a system key we trust it and set the `spaceId` to the
+            // dataSource.space.sId.
+            space = dataSource.space;
+          } else {
+            space = await SpaceResource.fetchWorkspaceGlobalSpace(auth);
+          }
+        } else {
+          return apiError(req, res, {
+            status_code: 400,
+            api_error: {
+              type: "invalid_request_error",
+              message: "Invalid space id.",
+            },
+          });
+        }
+      }
+
       if (
-        !dataSource ||
         dataSource.space.sId !== space.sId ||
         !spaceCheck(space) ||
         !hasPermission(auth, dataSource, options.dataSource)
@@ -277,7 +301,7 @@ function withDataSourceFromRoute<T, A extends SessionOrKeyAuthType>(
         req,
         res,
         auth,
-        { ...resources, dataSource },
+        { ...resources, space, dataSource },
         options,
         sessionOrKeyAuth
       );