Skip to content

Commit

Permalink
doc on convention on connector resource
Browse files Browse the repository at this point in the history
  • Loading branch information
philipperolet committed Sep 8, 2023
1 parent 74a96b9 commit 8e8c090
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions connectors/src/types/resources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,19 @@ export type ConnectorResourceType = "file" | "folder" | "database" | "channel";
* - Slack: channels
* - GoogleDrive: shared drive or sub-folders of shared drives.
*
* `internalId` and `parentInternalId` are internal opaque identifiers that should enable
* reconstructing the tree structure of the resources.
* `internalId` and `parentInternalId` are internal opaque identifiers that
* should enable reconstructing the tree structure of the resources.
*
* Those ids must be aligned with those used in the "parents" field of data
* sources documents, to enable search filter on documents based on their
* parents, see the
*
* The convention to use for internal ids are to always use the externally
* provided id when possible (e.g. Notion page id, Github repository id,
* etc...). When not possible, such as for Github issues whose id is not
* workspace-unique, a custom function to create a unique id is created, and
* used both in the parents field management code and the connectors resource
* code.
*/
export type ConnectorResource = {
provider: ConnectorProvider;
Expand Down

0 comments on commit 8e8c090

Please sign in to comment.