[front] Give access to all groups for system key (#9401)

dust-tt · Dec 16, 2024 · 9d95583 · 9d95583
1 parent 722a6c6
commit 9d95583
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 21 deletions.
diff --git a/front/lib/resources/group_resource.ts b/front/lib/resources/group_resource.ts
@@ -121,26 +121,16 @@ export class GroupResource extends BaseResource<GroupModel> {
   static async listWorkspaceGroupsFromKey(
     key: KeyResource
   ): Promise<GroupResource[]> {
-    let whereCondition: WhereOptions<GroupModel> = {
-      workspaceId: key.workspaceId,
-    };
-
-    // If the key is a system key, we also include the global group.
-    if (key.isSystem) {
-      whereCondition = {
-        ...whereCondition,
-        [Op.or]: [
-          { kind: { [Op.in]: ["system", "global"] } },
-          { id: key.groupId },
-        ],
-      };
-    } else {
-      // If it's not a system key, we only fetch the associated group.
-      whereCondition = {
-        ...whereCondition,
-        id: key.groupId,
-      };
-    }
+    const whereCondition: WhereOptions<GroupModel> = key.isSystem
+      ? // If the key is a system key, we include all groups in the workspace.
+        {
+          workspaceId: key.workspaceId,
+        }
+      : // If it's not a system key, we only fetch the associated group.
+        {
+          workspaceId: key.workspaceId,
+          id: key.groupId,
+        };
 
     const groups = await this.model.findAll({
       where: whereCondition,

diff --git a/...pages/api/v1/w/[wId]/spaces/[spaceId]/data_sources/[dsId]/documents/[documentId]/index.ts b/...pages/api/v1/w/[wId]/spaces/[spaceId]/data_sources/[dsId]/documents/[documentId]/index.ts
@@ -297,7 +297,7 @@ async function handler(
   if (
     !dataSource ||
     dataSource.space.sId !== spaceId ||
-    (!dataSource.canRead(auth) && !auth.isSystemKey())
+    !dataSource.canRead(auth)
   ) {
     return apiError(req, res, {
       status_code: 404,