Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Create workflow + invite issues: Post signup paywall despite workspace upgraded #9054

Open
spolu opened this issue Dec 2, 2024 · 6 comments
Assignees

Comments

@spolu
Copy link
Contributor

spolu commented Dec 2, 2024

When create a workspace + inviting + bump the workspace plan your still asked to subscribe through the flow

see https://groups.google.com/a/dust.tt/g/product-archive/c/O89zxFs9rN0

Important because this is the flow we use for our enterprise users

@philipperolet philipperolet self-assigned this Dec 3, 2024
@philipperolet
Copy link
Contributor

Started investigation. Timeline

  • on Dec 1, spolu creates the workspace, bumps it to Friends and family, and invites him
  • On dec 2, he creates a workspace at 1:07pm, and is at the same time a member of it, with NO_PLAN (workspace now marked "legacy")
  • 2mns later, at 1:09, he joins the workspace created by spolu

Here's the query with the right creation times for memberships / workspaces

I anticipate the issue just originates in him creating his own workspace in parallel of the existing one created by spolu

Will continue investigation to confirm

@philipperolet
Copy link
Contributor

philipperolet commented Dec 9, 2024

Vocabulary:

  • invitation screen => the white screen saying you've been invited to join a workspace
  • login screen => choosing between different signup options (google, ms, password) while not authenticated)
  • details screen => where we enter first / last name

TLDR

  1. confirmed there's a confusing situation with invitation screen appearing twice (on click on invitation link, then on clic on verification link)
  2. Issue there seems restricted to the choice of password auth (otherwise no verification link)
  3. AFAICT the flow otherwise works correctly;
    The issue is the confusion with having to clic signup twice; the second time (via verification link) should go directly to details screen (not requiring a clic on signup)

Tested

  • creating a workspace, inviting a fresh user (random gmail adress) as admin and bumping the workspace
  • invitation link recieved, on click: invitation screen. On click on sign up, login screen.
  • on login screen, if password auth chosen => get a verification link
  • on clic on link, gets invitation screen again; when clicking, get to details screen this time (not login screen)
  • then filling up and submitting => works smoothly afterwards: got in workspace as admin on a friend/family plan, with the right number of emails (1 invitation, 1 verification, 1 welcome)

Remaining:

  • testing with reloading when seeing the invitation screen the second time (as he did)
  • testing with changing name on signup as he did;
  • and trying to understand in what situation he got to change his name; unclear from his email, it would mean he got 2 details screens which doesn't seem to be the case, unless he clicked multiple times on verification/invitation links

It seems clear he created a workspace for himself; a hypothesis is that at some point he had started with password, then switched to using gmail and created a workspace, then came back to the initial auth

(edited)

@philipperolet
Copy link
Contributor

philipperolet commented Dec 14, 2024

After further investigation, damien had

  1. created himself a workspace, with an adress [email protected] on Nov 19, via google auth
  2. had one created by spolu on Dec 1 on adress [email protected], via user+password login
  3. created one for himself on Dec 2 on adresss [email protected], via user+password login

As such he had:

  • 2 entries in our auth0 (gmail + amblea)
  • 3 workspaces, 2 no-plans and 1 friends-family (the one created by spolu)

@philipperolet
Copy link
Contributor

philipperolet commented Dec 14, 2024

Furthermore, it's confirmed that when going through a regular invite, a user that did not have a pre-existing auth0 entry -- which will always happen if choosing to create a password -- will get to the invitation screen twice:

  1. when clicking on the email invitation link: at that time, goes direct to invitation screen, no user is created on dust nor on auth0
  2. after successfully logging in via auth0: at that time, auth0 redirects to dust.tt home, which sees a user with an invitation token and and redirects to invitation screen (at that time also creating the user if not existing already)

Cf issue #9053

@philipperolet
Copy link
Contributor

philipperolet commented Dec 14, 2024

  1. created one for himself on Dec 2 on adresss [email protected], via user+password login

To be confirmed if that creation was him trying to login our our app mistakenly creating one for himself in addition to the existing one

@philipperolet
Copy link
Contributor

Sitrep for this issue
While using the invitation link from spolu, a new workspace was created for damien in addition to the spolu one. Follow-up is to:

  • understand if in the flow he made he might have accidentally created it, or if in our code paths there is an accidental creation;
  • check why after he entered details, the authentication first directed him to the workspace he created, then to the workspace he joined (spolu one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants