Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flav/fix relocation worker temporal #10443

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Jan 31, 2025

Description

While testing in production the cross-region relocation, we noticed that some weird characters where not properly escaped from the SQL statement. This PR moves this to using replacements/bind on Sequelize which is known to automatically escape properly strings.

Tests

Risk

Deploy Plan

Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 👌🏼

@flvndvd flvndvd marked this pull request as ready for review January 31, 2025 15:42
@flvndvd flvndvd merged commit 2bd09a6 into main Jan 31, 2025
6 checks passed
@flvndvd flvndvd deleted the flav/fix-relocation-worker-temporal branch January 31, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants