feat: add support for bigquery in core #10447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraggle
reviewed
Feb 3, 2025
fontanierh
force-pushed
the
feat/core-support-bigquery
branch
from
8fa9d6d to
4ee69bc
Compare
fontanierh
changed the title
Fraggle
reviewed
Feb 3, 2025
Fraggle
reviewed
Feb 3, 2025
|
|
||
| query_result_size = query_result_size | ||
| + res | ||
| .total_bytes_processed |
There was a problem hiding this comment.
I think, this is the number of bytes read from bigquery data, not necessary the size of the payload, is it really what you want ?
There was a problem hiding this comment.
Ah interesting, not at all what I want and I think you might be right. Going to replace with the same approach we use for SF
There was a problem hiding this comment.
reverting to nb of rows for now
Fraggle
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for BigQuery remote databases in
core.The implementation supports all required features for a remote DB:
TableSchemafor a list of tablesWhat is not covered here:
Focused on merging quickly so we can test end to end and debug
Tests
Manual
Risk
N/A (pretty much no change to non-bigquery flow)
Deploy Plan
Deploy
core