Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index on retrieval_document_chunk #10458

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Add index on retrieval_document_chunk #10458

merged 1 commit into from
Feb 1, 2025

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Feb 1, 2025 •
edited
Loading

Description

The cross-region is migration on the retrieval_document_chunks as the query needs to hit two distinct indexes. This PR adds a new composite index.

Query to improve:

SELECT * FROM retrieval_document_chunks WHERE "workspaceId" = xxx ORDER BY id ASC LIMIT 2;

Tests

Risk

Deploy Plan

  • Apply index in 🇺🇸
  • Apply index in 🇪🇺

@flvndvd flvndvd marked this pull request as ready for review February 1, 2025 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025 •
edited
Loading

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 3af7c50

JulesBelveze
JulesBelveze approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@flvndvd flvndvd added the migration-ack 📁 Label to acknowledge that a migration is required. label Feb 1, 2025
@flvndvd flvndvd merged commit acb9aab into main Feb 1, 2025
11 checks passed
@flvndvd flvndvd deleted the flav/add-retrieval-documents-index branch February 1, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

Assignees
No one assigned
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flvndvd @JulesBelveze