Add: mcp support as client. #10833
Draft
Add: mcp support as client. #10833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraggle
requested review from
spolu,
fontanierh and
flvndvd
and removed request for
spolu
fontanierh
reviewed
Feb 17, 2025
| step: number; | ||
| } | ||
|
|
||
| const CONTEXT_SIZE_DIVISOR_FOR_OUTPUT = 2; |
| role: "function" as const, | ||
| name: "missing_function_call_name", | ||
| function_call_id: this.functionCallId ?? "missing_function_call_id", | ||
| content: `Error: the content was not tokenized`, |
There was a problem hiding this comment.
I don't understand this message
| role: "function" as const, | ||
| name: this.functionCallName, | ||
| function_call_id: "missing_function_call_id", | ||
| content: `Error: the content was not tokenized`, |
| role: "function" as const, | ||
| name: this.functionCallName, | ||
| function_call_id: this.functionCallId, | ||
| content: `Error: the content was not tokenized`, |
There was a problem hiding this comment.
this one I do understand :p
| role: "function" as const, | ||
| name: this.functionCallName, | ||
| function_call_id: this.functionCallId, | ||
| content: `Error: Action output has too many tokens to be included.`, |
There was a problem hiding this comment.
Should we rather truncate (and append somnething like "[X more characters truncated]") ?
| // the generation of the params. We store the action here as the params have been generated, if | ||
| // an error occurs later on, the error will be stored on the parent agent message. | ||
| const action = await AgentMCPAction.create({ | ||
| host: "remote", // TODO(mcp): add the host of the MCP tool dynamically |
There was a problem hiding this comment.
OOC can you provide a few more tokens regarding this comment ?
There was a problem hiding this comment.
I'm actually reworking this part, should be clearer (also, design doc incoming).
fontanierh
reviewed
Feb 17, 2025
| // - system: the MCP tool is running inside the Dust system | ||
| // - isolated: the MCP tool is running inside a isolated environment (e.g. in a container) | ||
| // - remote: the MCP tool is running outside the Dust system (e.g. on another machine) | ||
| export type MCPHostType = "client" | "system" | "isolated" | "remote"; |
| @@ -23,6 +24,9 @@ export type ConversationBaseActionType = | |||
| | "conversation_list_files_action" | |||
| | "conversation_include_file_action"; | |||
|
|
|||
| export type MCPBaseActionType = MCPActionType["type"]; | |||
| // will also support "external" (run by an external server), "custom" (run by us in isolation) and "system" (dust provided actions) | |||
There was a problem hiding this comment.
external -> remote and custom -> isolated ?
There was a problem hiding this comment.
yes, i iterated on naming quite a bit :)
Fraggle
force-pushed
the
sflory-mcp-draft
branch
from
e508aae to
e8fb292
Compare
Fraggle
added
the
sdk-ack
Fraggle
force-pushed
the
sflory-mcp-draft
branch
from
e8fb292 to
a707330
Compare
Fraggle
force-pushed
the
sflory-mcp-draft
branch
from
a707330 to
8b4a5cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR does 2 things:
Add support for Dust as an MCP client via a new MCPAction
This allow for an agent to run tools exposed by MCP servers.
Add a rudimentary MCP relay server
This allow MCP servers running on localhost (eg: in a Front "app") to be exposed to the dust agent.
It works by exposing a websocket endpoint for the localhost MCP Servers to connect to and keep.
On the other side, it expose itself as an http sse MCPServer to from the standpoint of the Dust Agent MCPClient, it's fully transparent.
The relay itself and the custom communication layer over websocket are very rudimentary, on that stand point it's really a POC.
The first goal is just to enable localhost MCP actions use-cases (to avoid a lot of UI complexity needed by the other uses cases).
Tests
Locally
Risk
Low, behind a feature flag.
Deploy Plan
Deploy the relay in our infra. Deploy
front