feat(resource-full-text-search): add text vector columns and GiST indexes for notion #1159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
connectors
db.ts
to enable theunaccent
extension if not yet enabled (tried to switch it on in prod, worked fine)titleSearchVector
TSVECTOR column onnotion_pages
andnotion_databases
GiST
index on thetitleSearchVector
column fornotion_pages
andnotion_databases
titleSearchVector
whenever thetitle
is updated on either anotion_pages
ornotion_databases
rowtitleSearchVector
on existingnotion_pages
andnotion_databases
rowsI went with GiST instead of GIN (means faster to insert/build, but slower to search). Rationale is that the dataset is not static, and will be more write-heavy than read-heavy. Wonder if that's the write choice ? WDYT @lasryaric @spolu ?