enh: sparkle-ization of app design #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
reviewed
Sep 1, 2023
| @@ -67,7 +80,7 @@ export default function AI21Setup({ owner, open, setOpen, config, enabled }) { | |||
|
|
|||
| return ( | |||
| <Transition.Root show={open} as={Fragment}> | |||
| <Dialog as="div" className="relative z-10" onClose={() => setOpen(false)}> | |||
| <Dialog as="div" className="relative z-30" onClose={() => setOpen(false)}> | |||
There was a problem hiding this comment.
FMI, why do we need to move to z-30 everywhere ?
There was a problem hiding this comment.
Standardizing all Dialogs as some of them woudl conflict with the AppLayout title 👍
fontanierh
previously approved these changes
Sep 1, 2023
| @@ -290,7 +290,7 @@ export default function AppLayout({ | |||
| </div> | |||
| <div | |||
| className={classNames( | |||
| "fixed left-0 right-0 top-0 z-30 flex h-16 flex-row lg:left-80", | |||
| "fixed left-0 left-12 right-0 top-0 z-30 flex h-16 flex-row lg:left-80", | |||
There was a problem hiding this comment.
Maybe we want to remove the left-0 then no ? Because I imagine only one of those 2 can apply ?
Super nit, but is the disabled state of the |
|
Yes => cc @Duncid |
|
(@Duncid already noted that it's a bit meh meh) |
|
Fixes dust-tt/tasks#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Duncid I'm not super fan of the title + tab below but it's not that bad. Given that it's not our core focus I presume it's good enough but let me know if you have some ideas on that.