Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last message timestamp when upserting Slack Messages #1289

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Use last message timestamp when upserting Slack Messages #1289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions connectors/src/connectors/slack/temporal/activities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,7 @@ export async function syncNonThreaded(
const documentId = `slack-${channelId}-messages-${startDateStr}-${endDateStr}`;
const firstMessage = messages[0];
let sourceUrl: string | undefined = undefined;
const createdAt = firstMessage?.ts
? parseInt(firstMessage.ts, 10) * 1000
: undefined;

if (firstMessage && firstMessage.ts) {
const linkRes = await client.chat.getPermalink({
channel: channelId,
Expand All @@ -397,6 +395,10 @@ export async function syncNonThreaded(
sourceUrl = linkRes.permalink;
}
}
const lastMessage = messages[messages.length - 1];
const createdAt = lastMessage?.ts
? parseInt(lastMessage.ts, 10) * 1000
: undefined;

const tags = getTagsForPage(documentId, channelId, channelName);
await SlackMessages.upsert({
Expand Down Expand Up @@ -531,9 +533,7 @@ export async function syncThread(

const firstMessage = allMessages[0];
let sourceUrl: string | undefined = undefined;
const createdAt = firstMessage?.ts
? parseInt(firstMessage.ts, 10) * 1000
: undefined;

if (firstMessage && firstMessage.ts) {
const linkRes = await client.chat.getPermalink({
channel: channelId,
Expand All @@ -543,6 +543,10 @@ export async function syncThread(
sourceUrl = linkRes.permalink;
}
}
const lastMessage = allMessages[allMessages.length - 1];
const createdAt = lastMessage?.ts
? parseInt(lastMessage.ts, 10) * 1000
: undefined;

const tags = getTagsForPage(documentId, channelId, channelName, threadTs);

Expand Down