Slack Sync updates slack docs parents Field #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Sep 6, 2023
| @@ -559,7 +559,7 @@ export async function syncThread( | |||
| documentUrl: sourceUrl, | |||
| timestampMs: createdAt, | |||
| tags, | |||
| parents: [], | |||
| parents: [channelId], | |||
There was a problem hiding this comment.
Any chance we could guarantee that we use the same Id here and in the connector ressource internal Id?
I worry we change one and not the other?
Maybe it;'s not possible and we leave a comment?
There was a problem hiding this comment.
As per slack thread, the convention is now to use external ids directly everywhere, so it is legit to leave it as is.
spolu
reviewed
Sep 8, 2023
| group: ["documentId", "channelId"], | ||
| }); | ||
| // update all parents fields for all pages and databases by chunks of 128 | ||
| const chunkSize = 128; |
There was a problem hiding this comment.
That's a lot of connections, maybe 32?
There was a problem hiding this comment.
will update in all 3 migrations
spolu
previously approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the similar Notion PR for review simplicity (there is a common change)
Much, much, much simpler than Notion
Same migration plan