Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sparkle): unify button props (always use variant vs type) #1309

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

fontanierh
Copy link
Contributor

follow up for #1297, which renamed the type property of Button to variant. For consistency, this commit does the same for IconButton and IconToggleButton

@fontanierh fontanierh requested review from Duncid and spolu September 7, 2023 14:57
@Duncid
Copy link
Contributor

Duncid commented Sep 7, 2023

Thanks, wanted to do that !

@Duncid
Copy link
Contributor

Duncid commented Sep 7, 2023

FYI, did it for Buttons in a previous PR.
But I did not change the front code base yet.
If you move the front to the new Sparkle package it will break (but you probably noticed already)

@fontanierh
Copy link
Contributor Author

FYI, did it for Buttons in a previous PR.
But I did not change the front code base yet.
If you move the front to the new Sparkle package it will break (but you probably noticed already)

Yes already updated front in prod for <Button /> :)

@fontanierh fontanierh merged commit 30fe38c into main Sep 7, 2023
1 check passed
@fontanierh fontanierh deleted the chore/unify-button-props branch September 7, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants