Better handling of parent type and parallelized update of fields #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix an issue related to unexpected parent types The issue generates unhandled activity errors, it was fixed earlier for null in PR #1318 . Another much rarer case is 'unknown'. Comments are added to explain 2. Speed up the update by parallelizing queries with a factor 16 (anticipating moving top level folders with e.g. 1OK docs => might take up to 30mns if not parallelized)
|
Simple code, that I tested well, so merging. Post-merge review welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue related to unexpected parent types The issue generates unhandled activity errors, it was fixed earlier for null in PR Handle null parent type case in notion #1318 . Another much rarer case is 'unknown'. Comments are added to explain
Speed up the update by parallelizing queries with a factor 16 (anticipating moving top level folders with e.g. 1OK docs => might take up to 30mns if not parallelized)