Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do await user message on create conversation (public API) + mode docs #1897

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Sep 29, 2023

We have an optimization in our internal route to create a conversation that does not await the userMessage being created before replying to more rapidly switch the UI to the new conversation UI client-side.

At the API level that makes no sense. Fixes that and update the documentation to document posting new user messages separately.

@spolu spolu requested a review from lasryaric September 29, 2023 14:51
@spolu spolu changed the title Do await user message on create conversation + mode docs Do await user message on create conversation (public API) + mode docs Sep 29, 2023
@spolu spolu merged commit 2a49ed8 into main Sep 29, 2023
2 checks passed
@spolu spolu deleted the spolu-tweak_v1_api branch September 29, 2023 14:52
@spolu
Copy link
Contributor Author

spolu commented Sep 29, 2023

Will make sure to test the slack bot once it's out

@lasryaric
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants