feat: display list of retrived documents when clicking on the chip #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we try to align the results with the chip. |
Will move to a grid layout @spolu 👍 |
|
@spolu addressed the alignment Regarding the mobile thing, this is what it looks like rn: Think it's ~OK ? Would you rather not have the # of retrieved docs on small screens ? |
|
Yes let’s remove on mobile as it’s non critical. do we need an icon in the ship to show that it’s clickable? |
spolu
previously approved these changes
Oct 3, 2023
| <li key={i}> | ||
| <a | ||
| href={document.sourceUrl || ""} | ||
| className="front-bold text-element-800" |
There was a problem hiding this comment.
shouldn't it be text-xs to be aligned with the text size of the retrieval component?
|
Killed on phone + added a chevron icon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pending discussion here