TextSynth support #1919
Merged
TextSynth support #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
previously approved these changes
Oct 2, 2023
core/src/providers/textsynth.rs
Outdated
|
|
||
| let response = match status { | ||
| hyper::StatusCode::OK => { | ||
| // print content of c |
There was a problem hiding this comment.
copilot prompt to cleanup
| Some(api_key) => { | ||
| self.api_key = Some(api_key.clone()); | ||
| } | ||
| None => match tokio::task::spawn_blocking(|| std::env::var("TEXTSYNTH_API_KEY")).await? |
There was a problem hiding this comment.
Does this need spawn blocking ? Would have expected this to not be cpu bound
There was a problem hiding this comment.
yeah this is cargo-culted... we can clean-up everywhere. The thing is that std::env::var is kinda blocking but we can probably optimize
core/src/providers/textsynth.rs
Outdated
| if m == -1 { | ||
| let tokens = self.encode(prompt).await?; | ||
| max_tokens = Some((self.context_size() - tokens.len()) as i32); | ||
| // println!("Using max_tokens = {}", max_tokens.unwrap()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for provider
textsynthwith models to be used inllmblocks.First pass:
Will tackle these in subsequent PRs.