add ability to edit a conversation title #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Oct 2, 2023
| className="w-full rounded-md font-bold" | ||
| value={editedTitle} | ||
| onChange={(e) => setEditedTitle(e.target.value)} | ||
| // this is to make sure the save button click |
There was a problem hiding this comment.
Comments are sentences :) Upper-case and a . at the end
This comment is intriguing. Just enough to hook you up, not enough to understand :p
| </div> | ||
| </div> | ||
| ) : ( | ||
| <IconButton |
There was a problem hiding this comment.
The alignment is not perfect here the icon is a bit above the text? Can we tweak it a bit?
Also that gray looks not super sharp maybe we can use the flavour that is darker?
| } | ||
| ); | ||
| await mutate( | ||
| `/api/w/${owner.sId}/assistant/conversations/${conversationId}` |
There was a problem hiding this comment.
You want to mutate conversations as well to update the left-hand pane?
There was a problem hiding this comment.
Indeed. That's a whole lot of refetching for just a title :(
fontanierh
force-pushed
the
feat/edit-title
branch
from
06e1ce7 to
f155800
Compare
spolu
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.