Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client-side conversation participants #1935

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Oct 3, 2023

Context is described here: #1883

@PopDaph PopDaph requested a review from spolu October 3, 2023 19:23
}: {
conversation: ConversationType;
}) {
type UserParticipant = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want this to be forbidden but as they are only used here and have no point being exported I put them directly in the component!

Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥💯

@PopDaph PopDaph merged commit 88d6133 into main Oct 3, 2023
1 check passed
@PopDaph PopDaph deleted the client-side-participants branch October 3, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants