Cookie Banner homepage #2400
Merged
Cookie Banner homepage #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
requested review from
Duncid and
spolu
and removed request for
Duncid
PopDaph
force-pushed
the
cookie-banner
branch
from
e8d955d to
a20e48f
Compare
spolu
previously approved these changes
Nov 6, 2023
front/pages/index.tsx
Outdated
| > | ||
| <div className="text-sm font-normal text-element-900"> | ||
| We use cookies to improve your experience on our site. By using our | ||
| service, you agree to our{" "} |
There was a problem hiding this comment.
Aren't the terms supposed to go in the sign-in flow? Let's make this one as small as possible especially if we don't store the fact that you accepted at all when you come back (and haven't signed in of course)
front/pages/index.tsx
Outdated
| )} | ||
| > | ||
| <div className="text-sm font-normal text-element-900"> | ||
| We use cookies to improve your experience on our site. By using our |
There was a problem hiding this comment.
Let's link cookies to our cookie policy (target _blank) ?
|
@spolu I added a commit: |
PopDaph
force-pushed
the
cookie-banner
branch
from
76fdd05 to
655bc20
Compare
|
Prettified it with Ed: |
|
|
Thanks! π― |
spolu
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the most basic we can do.
It does not move. ππ»ββοΈ
It load GA only if accepted. It is displayed again if we refresh.
Review with hidden whitespaces: https://github.com/dust-tt/dust/pull/2400/files?diff=split&w=1