Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Scrub deleted Data Sources Documents #2495

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Nov 11, 2023

Can be run multiple times. Future: add a way to start from a timestamp.

To run: simply use a front box (that's where I added the blake3 dep)

@spolu spolu force-pushed the spolu-scrub_deleted_gcs branch from 2a18770 to ed034d2 Compare November 13, 2023 15:18
@spolu spolu changed the title [WIP] core: Scrub deleted Data Sources Documents core: Scrub deleted Data Sources Documents Nov 13, 2023
@spolu spolu requested a review from fontanierh November 13, 2023 15:41
fontanierh
fontanierh previously approved these changes Nov 13, 2023
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except not sure I understand the comment at the top

import { createHash } from "blake3";
import { Sequelize } from "sequelize";

// To be run from connectors with `CORE_DATABASE_URI`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be in the connectors directory then ? or is the comment wrong ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cargo culted can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually need to be run from front as this is where the blake3 dep is

@spolu spolu merged commit 526e943 into main Nov 13, 2023
1 check passed
@spolu spolu deleted the spolu-scrub_deleted_gcs branch November 13, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants