-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Production checks] Gdrive GC #2505
Conversation
We also need CORE_DATABASE_URI and CONNECTORS_DATABASE_URI to be added to front so that we have access to all SQL moving forward |
You mean on top of the RO version?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is hard to read TBH
Let's make things simple. Separate in two checks one for Slack one for Gdrive
For GDrive let's stick with the migration flow that is easy to understand.
Take all connector file ids and create a hash (that's fine that holds in memory)
Then take all core document_id and check them.
No chunking, it's easier to understand and can be read more easily
The fact that you try to do both at the same time makes it hard to understand and read. We need DEAD simple here otherwise we'll not maintain it.
Adding production checks for Gdrive.
Deployment steps:
Add the following 3 env vars to front:
Check if the workflow is properly running on Temporal Cloud.
Setup Datadog Alerts
Production check failed
is emittedDone running all checks
is not trigger within a 90 minutes time frame.