Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front: Display Intercom connections as coming soon #2569

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Nov 16, 2023

Looks like a lot of code but no complex logic, this PR is only about adding to the Plan db and type a "isIntercomAllowed".
UI changes for the members are on the Connection pages, where we display this new button.

Deployment

Requires a db migration: ./admin/init_db.sh to add the new field isManagedIntercomAllowed to Plan.
Requires updating the Prod pro plan afterward to set intercom allowed to true.

UI Change

Screenshot 2023-11-16 at 15 50 00

@PopDaph PopDaph requested review from spolu and fontanierh November 16, 2023 14:52
@PopDaph
Copy link
Contributor Author

PopDaph commented Nov 16, 2023

This PR is the best way to motivate myself to quickly ship this new connector 😅

fontanierh
fontanierh previously approved these changes Nov 16, 2023
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PopDaph
Copy link
Contributor Author

PopDaph commented Nov 16, 2023

@spolu
Copy link
Contributor

spolu commented Nov 16, 2023

🔥

@PopDaph PopDaph merged commit 46690a2 into main Nov 17, 2023
2 checks passed
@PopDaph PopDaph deleted the front-intercom-coming-soon branch November 17, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants