Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: data_source block, replace variables in filter.tags #2613

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Nov 21, 2023

  • This PR aims to allow the replacement of variables in the tags provided as config to a data_source block.

The use-case goes as follow:

The app receive as input a tag to filter on. The app, applies filtering received as input (or other block output) on a data source block for parameterized filtering of the retrieval step.

Screenshot from 2023-11-21 17-15-43

@spolu spolu assigned spolu and unassigned spolu Nov 21, 2023
@spolu spolu requested a review from PopDaph November 21, 2023 16:19
Copy link
Contributor

@PopDaph PopDaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@spolu spolu merged commit 0462a55 into main Nov 21, 2023
2 checks passed
@spolu spolu deleted the spolu-core_data_source_filters branch November 21, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants