Override Notion Client logger #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Nov 22, 2023
| message: string, | ||
| extraInfo: Record<string, unknown> | ||
| ) => { | ||
| console.log(`[${level}]: ${message}`, extraInfo); |
There was a problem hiding this comment.
Why not directly use a logger here? potentially deactivating after that?
There was a problem hiding this comment.
We def don't want those logs to clutter our DD errors no ? The'll handle the requests to notion, and we'll do the logging if where we need it wdyt ?
There was a problem hiding this comment.
I'm not too worried about cluttering. But my point here is that console.log will clutter more than logger ?
There was a problem hiding this comment.
I removed the console.log and no-op instead > want me to add back a log in info?
There was a problem hiding this comment.
OK added back with a logger.info so we keep them but stop being spammed with errors
spolu
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to prevent NotionClient to spam our datadog: https://app.datadoghq.eu/logs?query=-status%3A%28warn%20OR%20info%29&cols=host%2Cservice&index=%2A&messageDisplay=inline&refresh_mode=sliding&stream_sort=desc&viz=stream&from_ts=1700649104874&to_ts=1700650004874&live=true