-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: database_schema support in dust apps #2624
Conversation
ba27f42
to
cdd7e32
Compare
cdd7e32
to
def4ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good left a few minor comments
</div> | ||
</div> | ||
{block.config.database?.data_source_id && ( | ||
<div className="flex flex-col xl:flex-row xl:space-x-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try to put them on the same line on wide screen (and vertical alignment on small screens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -164,7 +170,7 @@ export default function NewBlock({ | |||
))} | |||
</div> | |||
</div> | |||
<div className="col-span-8 pr-2 text-sm text-gray-700 sm:col-span-9 sm:pl-3"> | |||
<div className="col-span-8 pr-2 text-sm text-gray-700 sm:col-span-9 sm:pl-6"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because database_schema
was too long?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
) : databases && databases.length > 0 ? ( | ||
"Select Database" | ||
) : ( | ||
"There are no databases in this data source." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THat's button-ish UI right? should this be "No Databases" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is button-ish indeed, will change 👍
14e4f32
to
1a559ea
Compare
It works:
I think I didn't miss any place 🤞