Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database_schema support in dust apps #2624

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Nov 22, 2023

It works:

Screenshot 2023-11-22 at 17 32 07 Screenshot 2023-11-22 at 17 32 16

I think I didn't miss any place 🤞

@fontanierh fontanierh force-pushed the feat/databases-support-in-dust-apps branch 2 times, most recently from ba27f42 to cdd7e32 Compare November 22, 2023 15:10
@fontanierh fontanierh force-pushed the feat/databases-support-in-dust-apps branch from cdd7e32 to def4ec9 Compare November 22, 2023 15:10
@fontanierh fontanierh changed the title WIP Feat/databases support in dust apps feat: database_schema support in dust apps Nov 22, 2023
@fontanierh fontanierh requested review from spolu and PopDaph November 22, 2023 15:55
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good left a few minor comments

</div>
</div>
{block.config.database?.data_source_id && (
<div className="flex flex-col xl:flex-row xl:space-x-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try to put them on the same line on wide screen (and vertical alignment on small screens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -164,7 +170,7 @@ export default function NewBlock({
))}
</div>
</div>
<div className="col-span-8 pr-2 text-sm text-gray-700 sm:col-span-9 sm:pl-3">
<div className="col-span-8 pr-2 text-sm text-gray-700 sm:col-span-9 sm:pl-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because database_schema was too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

front/lib/config.ts Outdated Show resolved Hide resolved
) : databases && databases.length > 0 ? (
"Select Database"
) : (
"There are no databases in this data source."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THat's button-ish UI right? should this be "No Databases" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is button-ish indeed, will change 👍

@fontanierh fontanierh force-pushed the feat/databases-support-in-dust-apps branch from 14e4f32 to 1a559ea Compare November 22, 2023 16:30
@fontanierh fontanierh requested a review from spolu November 22, 2023 16:31
spolu
spolu previously approved these changes Nov 22, 2023
@fontanierh fontanierh merged commit 1934f72 into main Nov 22, 2023
2 checks passed
@fontanierh fontanierh deleted the feat/databases-support-in-dust-apps branch November 22, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants