Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to silent npm run #2627

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Attempt to silent npm run #2627

merged 1 commit into from
Nov 23, 2023

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Nov 22, 2023

🤞🏻

spolu
spolu approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test on edge ;-)

@PopDaph
Copy link
Contributor Author

PopDaph commented Nov 22, 2023

Yes that's exactly how I discovered edge was broken 😅

@PopDaph
Copy link
Contributor Author

PopDaph commented Nov 23, 2023

Front edge seems to work > I was able to create a convo.
I'm guessing everything would have been broken if config was not right. I'm not sure this will properly silent the logs we want to get rid of but at least it does not seem harmful.

@PopDaph PopDaph merged commit df3858c into main Nov 23, 2023
6 checks passed
@PopDaph PopDaph deleted the silent-npm branch November 23, 2023 10:38
@PopDaph
Copy link
Contributor Author

PopDaph commented Nov 23, 2023

It did not work 😭
Screenshot 2023-11-23 at 12 17 06

@spolu
Copy link
Contributor

spolu commented Nov 23, 2023

glups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PopDaph @spolu