Batch render user/agent messages & content fragments #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Nov 27, 2023
PopDaph
force-pushed
the
batch-render-user-message
branch
from
743ad37 to
32ad485
Compare
PopDaph
commented
Nov 27, 2023
| const agents = ( | ||
| await Promise.all( | ||
| agentConfigurationIds.map(async (agentConfigId) => { | ||
| return await getAgentConfiguration(auth, agentConfigId); |
There was a problem hiding this comment.
I took a shortcut here, WDYT? I think it's worth shipping with it and iterate if we want to optimize again.
| ); | ||
| return await Promise.all( | ||
| agentRetrievalActionIds.map(async (agentRetrievalActionId) => { | ||
| return await renderRetrievalActionByModelId(agentRetrievalActionId); |
There was a problem hiding this comment.
Same kind of shortcut here!
PopDaph
changed the title
PopDaph
force-pushed
the
batch-render-user-message
branch
from
141aa77 to
d2de821
Compare
* code simplification * nit * clean-up
PopDaph
force-pushed
the
batch-render-user-message
branch
from
10d62aa to
763d715
Compare
spolu
reviewed
Nov 28, 2023
| @@ -498,6 +498,9 @@ Message.init( | |||
| unique: true, | |||
| fields: ["conversationId", "rank", "version"], | |||
| }, | |||
| { | |||
| fields: ["conversationId"], | |||
There was a problem hiding this comment.
Should be covered by the index above?
There was a problem hiding this comment.
I removed it and instead I updated the query to fetch the reactions to load only the sId of messages, which is the only field we use.
PopDaph
force-pushed
the
batch-render-user-message
branch
from
b530934 to
1ef9172
Compare
spolu
approved these changes
Nov 28, 2023
PopDaph
added a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.