Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkle50 #2755

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Sparkle50 #2755

merged 9 commits into from
Dec 5, 2023

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Dec 4, 2023

Large refactor of the input bar:

  • Bigger input zone
  • New layout
  • Fullscreen mode

@Duncid Duncid requested a review from spolu December 4, 2023 14:54
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually a required fix:

  • stop generation is broken:
    Screenshot from 2023-12-04 16-19-09

A welcome improvement:

  • nit: the icon should have non white background and maybe ideally we don't let the text go below

Screenshot from 2023-12-04 16-18-48

@spolu
Copy link
Contributor

spolu commented Dec 4, 2023

Ah I see now what you're doing with the buttons (backgdrop + round corner) by looking at mobile where it's more visible. Works for me. So I guess the main problem is the stop generation regression

Screenshot from 2023-12-04 16-26-31

@Duncid
Copy link
Contributor Author

Duncid commented Dec 4, 2023

Yes I couldn't test it on my local -_-'
I'm waiting for front-edge to take a look.

@Duncid Duncid merged commit bec002c into main Dec 5, 2023
@Duncid Duncid deleted the Sparkle50 branch December 5, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants