Fix filtering of deleted synced sheets #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
commented
Mar 7, 2024
| @@ -435,6 +435,7 @@ export async function syncSpreadSheet( | |||
| // List synced sheets. | |||
| const syncedSheets = await GoogleDriveSheet.findAll({ | |||
| where: { | |||
| connectorId: connector.id, | |||
|
PMRW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the filtering logic used to determine deleted synced sheets. Previously, the code relied on the truthiness of the
find()result to filter out synced sheets that were successfully imported. However, this approach could lead to incorrect filtering if a sheet ID contained the value0, as0is falsy in JavaScript.Risk
Deploy Plan