Augment session wrapper SSR #4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
approved these changes
Mar 8, 2024
front/lib/iam/session.ts
Outdated
| @@ -83,39 +83,74 @@ export async function getUserFromSession( | |||
| }; | |||
| } | |||
|
|
|||
| export type AuthLevel = "none" | "user" | "superuser"; | |||
There was a problem hiding this comment.
Maybe find another name that does not involve "Auth" as this is otherwise easy to confuse with Authenticator Roles? If no good other name, let's add a comment here to clarify that.
There was a problem hiding this comment.
Went with UserPrivilege.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the wrapper introduced in to go one step further and create the authenticator object needed to check and access resources.
This PR enhances the SSR wrapper from #4140 by creating the authenticator object required for checking and accessing resources in a centralized place. It also introduces a new wrapper
withSuperUserAuthRequirementsuse to gate all poke server side rendering to superuser.Risk
Deploy Plan