Proactively cancel inactive trials 3 days before end #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
approved these changes
Apr 3, 2024
front/lib/workspace_usage.ts
Outdated
| const sevenDaysAgo = new Date(); | ||
| sevenDaysAgo.setDate(sevenDaysAgo.getDate() - 7); | ||
|
|
||
| const hasConnectedDataSource = await DataSource.findOne({ |
There was a problem hiding this comment.
We want to consider as active if there's a Connection or if there's a Connection or a Folder?
There was a problem hiding this comment.
Connection and folder do create a data source 🙃.
| /** | ||
| * Proactively cancel inactive trials. | ||
| */ | ||
| export async function maybeCancelInactiveTrials( |
There was a problem hiding this comment.
NIT suggestion: Since this will I believe not be reusable anywhere else I would kill and do that directly on the webhook. ff we want to keep here I would just rename to be clearer -> cancelSubscriptionIfInactiveTrial
There was a problem hiding this comment.
I plan to use it in a script to cancel the trials that won't be captured by this change.
lasryaric
reviewed
Apr 4, 2024
flvndvd
added a commit
that referenced
this pull request
May 26, 2024
* Proactively cancel inactive trials 3 days before end * ✂️ * ✨ * Send email when canceling trial proactively * ✂️ * Log in Slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/dust-tt/tasks/issues/608.
This PR introduces a listener for Stripe's
customer.subscription.trial_will_endevent, which is triggered 3 days before a trial ends. On this event, we assess whether the trial has been active, based on the following criteria:If none of the above criteria are met, we will proactively cancel the subscription.
We will also send an email when proactively canceling a trial, this will be done in a follow up PR.
Risk
Deploy Plan