Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last 6 digits of external ID #4588

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Use last 6 digits of external ID #4588

merged 1 commit into from
Apr 5, 2024

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Apr 5, 2024

Description

In #4580, we limited the external table name to 32 characters. However, we've noticed conflicts where a single Google Spreadsheet can contain multiple sheets with the same last 4 trailing digits.

To address this, this PR allows for up to 6 trailing digits to be used when constructing the table name. This could potentially make it more challenging for the model to generate queries to target those tables.

Risk

Deploy Plan

@flvndvd flvndvd marked this pull request as ready for review April 5, 2024 11:09
@flvndvd flvndvd self-assigned this Apr 5, 2024
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the model, maybe we'll want some kind of "display name" for tables, but we still need to find a way to make them "locally" unique... Maybe when we build the DB / render the schema we can just add _1, _2 etc.. if needed to dedup ?

@flvndvd flvndvd merged commit f1e0e43 into main Apr 5, 2024
3 checks passed
@flvndvd flvndvd deleted the flav/improve-table-name branch April 5, 2024 12:43
@flvndvd
Copy link
Contributor Author

flvndvd commented Apr 5, 2024

LGTM. For the model, maybe we'll want some kind of "display name" for tables, but we still need to find a way to make them "locally" unique... Maybe when we build the DB / render the schema we can just add _1, _2 etc.. if needed to dedup ?

Seen IRL, will do in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants