Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Favorites preview #8016

Closed
wants to merge 10 commits into from
Closed

[UX] Favorites preview #8016

wants to merge 10 commits into from

Conversation

aubin-tchoi
Copy link
Contributor

Description

Note: the changes in this CL rely on the old "in-list" parameters and are not plugged on changes in the backend that are related to the new Favorites feature.

Risk

Deploy Plan

  • Deploy front

Fraggle and others added 10 commits October 11, 2024 11:00
* Refactor: extract DustApi to it's own package

* Use concurrently for npm run dev and avoid running other dependencies manually

* fix dockerfile

* Review fdbk
* [front/pages/w] - fix: reverse year iteration in workspace admin

 - Loop through years in descending order to match expected order in the admin workspace UI

[front/poke] - refactor: remove unused `LightWorkspaceType` import

 - Clean up import statements by removing `LightWorkspaceType` which is not utilized in `swr/plugins.ts`

* [front] - refactor: simplify import statements in swr plugins

 - Consolidate multiple import lines from "@dust-tt/types" into a single line

---------

Co-authored-by: Jules <[email protected]>
Description
---
Fixes dust-tt/tasks#1438

In curl block, there were successive calls to `replace_variables` and
`replace_secrets` for URL that both ran tera variable replacement,
making it fail.

Furthermore, secrets were not included in the env so could not have
been replaced.

Another option would have been to go with only string replacement (not
tera) for secrets but tera seemed the standard way to go, + it removed
the most code

Risks
---
Blast radius limited to secrets replacement in url. Tested locally.

Deploy
---
core
* Add missing webcrawler pages index

* Add SQL migration

* Add missing index on webcralwer folder

* Add migration

* Create index concurrently
* Improve vaults copy

* Update front/components/vaults/VaultLayout.tsx

Co-authored-by: Jules Belveze <[email protected]>

---------

Co-authored-by: Jules Belveze <[email protected]>
* [front/components/poke] - refactor: replace PokeInput with Sparkle Input component

 - Unified form input implementation using the Sparkle Input component across various forms and UI elements
 - Removed the now obsolete PokeInput component to streamline the codebase and adhere to the UI component standard

[front/components/poke/plans] - fix: correct plan editing to use event target value

 - Fixed an issue where editing a plan didn't correctly update the state with the new values entered by the user

[.] - refactor: remove reference to deleted PokeInput component from imports

 - Cleaned up import statements to remove references to the deleted PokeInput component, ensuring consistency in codebase

* [front] - refactor: clean up input field onChange handling in forms

 - Abstract destructuring of field object for cleaner assignment of onChange and value props in InputField
 - Ensure enum field value is converted to string for consistent handling in PluginForm component

---------

Co-authored-by: Jules <[email protected]>
…th imported Label component (#8009)

- Remove custom `PokeLabel` and use `Label` from `@dust-tt/sparkle` package across form and table components
 - Delete the now unused `label.tsx` file in the UI folder

Co-authored-by: Jules <[email protected]>
* Unleash vaults

* 🔙
* Sparkle config for compatibility

* Sparkle config for compatibility

* bumping

* Chips update
@aubin-tchoi aubin-tchoi self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants