front: show dust incidents in UI #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PMRR it works on front-edge
|
flvndvd
reviewed
Oct 21, 2024
| ); | ||
| const { providersStatus, dustStatus } = appStatus; | ||
|
|
||
| if (dustStatus) { |
There was a problem hiding this comment.
So we can only display one banner at a time?
There was a problem hiding this comment.
dust has priority on providers. Only one at a time
flvndvd
pushed a commit
that referenced
this pull request
Oct 21, 2024
flvndvd
added a commit
that referenced
this pull request
Oct 21, 2024
* Augment VaultResource constructor to support many groups * Add support for unrestricted vaults * ✨ * Restrict write to builder for unrestricted vault * ✨ * 👕 * 🙈 * 👕 * ✂️ * Restructure vaults side bar * 👕 * Change wording * Update front/components/vaults/VaultSideBarMenu.tsx Co-authored-by: Jules Belveze <[email protected]> * move * Fix upsert doc (#8087) * add esbuild/linux-x64 (#8090) * [front] Fix size error check, display error message (#8086) * [connectors] Use findOrCreate (#8089) * [Confluence] Remove mutex lib, use cacheWithRedis with lock (#8077) * [Confluence] Remove mutex lib, use cacheWithRedis with lock Description --- After IRL discussion & ensuing thinking: - remove the `async-mutex` lib (using a mutex library is bad form in general) - use cacheWithRedis for the confluence case (see details in PR #7906 for the need for this caching) - adds a custom lock to cacheWithRedis. For cacheWithRedis, a lock is legitimate (and needed to adress the initial issue of #7906), but in order to limit the scope of locking and avoid spreading its use in our codebase, we use a simple self-made inline implementation rather than a lib. Locking operation is quite fast, it shouldn't impact run (but waiting for the lock could and will). Implementing the lock could have the added benefit of fixing former unnoticed issues of caching not being used efficiently. Risks --- Blast radius: all cacheWithRedis calls => careful. See deploy plan Deploy plan --- - local tests on a few cachewithredis calls - deploy connectors - deploy front - monitor deployment - warn eng runner * add locking * comment * move unlock inside finally * make locking optional * [front] - refactor: ditch `Pokepopver` (#8095) * [front/components/poke/shadcn/ui] - refactor: switch to @dust-tt/sparkle for popover components - Replaced custom `PokePopover` components with `PopoverRoot`, `PopoverTrigger`, and `PopoverContent` from `@dust-tt/sparkle` library - Removed the now unused `PokePopover` definitions and imports to clean up the component module [.] - remove: delete unused popover component definitions - Deleted `popover.tsx` file as its components are replaced by those from `@dust-tt/sparkle` library * [front/ui] - refactor: wrap PopoverTrigger with 'asChild' prop - Use 'asChild' prop on PopoverTrigger to ensure proper integration with styled-component libraries or design systems --------- Co-authored-by: Jules <[email protected]> * Fix linter extension (#8097) * [sparkle] - enh: `RadioGroup` (#8040) * [sparkle] - feature: add @radix-ui/react-radio-group to dependencies - Introduced @radix-ui/react-radio-group library for managing radio button group UI components - Included all necessary peer dependencies and submodules to ensure full functionality of the radio group components * [sparkle] - feature: implement RadioGroup component - Added new RadioGroup and RadioGroupItem components for handling radio button functionality - Introduced a RadioGroup story in Storybook to demonstrate usage of the new components - Updated the main component index to export RadioGroup and RadioGroupItem components * [sparkle/components] - refactor: remove RadioButton component and stories - Deleted the RadioButton component as it is no longer required - Associated storybook stories for RadioButton also removed to reflect the changes in components * [sparkle] - feature: enhance RadioGroup with tooltips and new choice component - Add support for tooltips in RadioGroupItem with optional child rendering - Introduce new RadioGroupChoice component for more layout flexibility - Extend RadioGroupItem to support different icon positions within RadioGroupChoice - Update exports to include the new RadioGroupChoice component - Showcase new features and usage in updated storybook examples * [sparkle] - refactor: rearrange class order in Tooltip component - Adjust CSS class ordering to follow a logical pattern for easier maintenance - Add toggle for using `trigger` as a direct child in the Tooltip component to enhance flexibility in usage * [sparkle] - feature: bump package version to 0.2.268 - Update the package version in both package.json and package-lock.json for a new release * [sparkle] - feature: bump package version to 0.2.269 - Update package version in both package.json and package-lock.json files to ensure consistent dependency resolution * [sparkle] - refactor: update styles for Checkbox and RadioGroup components - Remove `s-border-primary-500` style from Checkbox to simplify its appearance - Simplify RadioGroup by removing `s-border-primary-500` and adjusting RadioGroupItem with Tooltip logic - Update Tooltip component's styling, removing the specific background color `s-bg-primary-50` for more consistency * [sparkle] - refactor: streamline class naming and component formatting - Standardize the ordering of class names for consistency in Dialog component - Clean up unnecessary parentheses and formatting across Page, Popover, and Separator components - Remove redundant styling classes for clarity in RadioGroup and TextArea components - Update class name ordering for visual styling and consistency in PopoverContent - Adjust the Separator component for better readability and consistency - Nest Tooltip trigger within child component for cleaner structure - Simplify Popover stories by streamlining trigger and content components * fix: package * [sparkle] - fix: remove duplicate border styling from Popover component - Removed a redundant border class in Popover's styling to clean up the CSS rules. * [sparkle] - refactor: update RadioGroupWithChildrenExample to use state - Refactored the story to manage RadioGroup selection state using React.useState - Replaced the hardcoded RadioGroupChoice components with a dynamic list mapped from a choices array - Added display logic to show a selection indicator next to the selected choice --------- Co-authored-by: Jules <[email protected]> Co-authored-by: Jules <[email protected]> * [front] - enh: use `RadioGroup` (#8082) * [front/components] - refactor: standardize checkbox component integration - Replace string literals for checkbox states with a structured CheckboxStatus object to improve code clarity and consistency - Update Checkbox component usage across various components to align with the new CheckboxStatus implementation [front/package] - fix: update @dust-tt/sparkle dependency to latest version - Ensure compatibility with new CheckboxStatus structure by updating the @dust-tt/sparkle dependency to the latest RC version - Include updates to related checkbox components from @radix-ui/react-checkbox to maintain alignment with dependency changes * [front] - refactor: replace PokeCheckbox with Checkbox from sparkle library - PokeCheckbox has been replaced with Checkbox across different components for consistency - Import of PokeCheckbox has been removed as it's no longer used * [front/components/poke/plans] - refactor: reorder imports in createPlan component - Adjust the order of component imports to follow convention [misc] - remove: delete obsolete checkbox component - Remove the PokeCheckbox component as it's no longer in use * [front] - fix: correct event handler for Checkbox component in form - Replace `onChange` with `onCheckedChange` to correctly handle state changes when checkboxes are toggled in the editing plan form * [front] - fix: ensure proper state update on selection change in tree - Replace direct state manipulation with controlled component behavior when a tree item is checked - Resolve issue with partial selection state not updating correctly upon user interaction * [front] - refactor: streamline checkbox component interface and usage - Replaced individual checked and onChange props with defaultChecked and onCheckedChange for Checkbox components across various modules - Simplified getCheckedState function in ContentNodeTree.tsx by returning a string state instead of an object with boolean flags - Adjusted logic handling the checked state of tree items to accommodate the new return type of getCheckedState function - Ensured consistent behavior of checkbox components and their interaction within the application's various features * [front/components] - refactor: standardize checkbox checked state representation - Replace the mixed usage of "checked", "unchecked", and "partial" string literals with booleans and a "partial" string where necessary - Simplify the logic in various components to work with the standardized state representation [front] - fix: correct spacing in import statement in createPlan.tsx - Ensure consistent code style by fixing the spacing between imported components [front] - devops: update @dust-tt/sparkle package to version 0.2.266-rc-2 - Bump the version of @dust-tt/sparkle to incorporate the latest changes and fixes in the project dependencies * [front] - fix: use controlled component pattern for checkboxes - Changed Checkbox components from uncontrolled to controlled by using the `checked` prop instead of `defaultChecked` - Ensures the Checkbox components properly react to state changes for consistent user experience across the application * [front] - feature: upgrade @dust-tt/sparkle to version 0.2.267 - Update the @dust-tt/sparkle package from a release candidate to the stable version - Resolve package-lock.json to point to the new version with updated integrity checksums * [front] - fix: correct checkbox disabled state and manage checked status in DataSourceViewSelector - Ensure that checkboxes are not incorrectly disabled in the `ContentNodeTree` by removing the disabling condition - Manage the checked state in `DataSourceViewSelector` with a new state hook to reflect partial and full selection states - Updated the checkbox `onCheckedChange` handler to maintain internal component state and trigger the `handleSelectAll` function * [front] - fix: make node selection consistent and address partial selection state - Ensure that child nodes are correctly disabled when the parent is selected - Address the indeterminate state to consistently apply a true selection state - Wrap the function call in `useEffect` to properly update partial selection state based on dependencies - Modify the checkbox behavior to hide it conditionally when no child items are partially checked - Add missing semicolon at the end of `handleSelectAll()` function call for consistency * [front] - fix: update dependency array in DataSourceViewSelector hook - Include `selectionConfiguration.isSelectAll` in the dependency array to ensure correct re-rendering when selection state changes * fix: lint/format * [front] - refactor: optimize checked state management in DataSourceViewSelector - Removed useState for isChecked in favor of useMemo to derive state directly from selection configuration - Simplified useEffect logic by removing it and directly assigning checked state within the component render flow - Streamlined handleSelectAll callback to control checked state without setting local state in the component * [front] - refactor: simplify useEffect dependencies in DataSourceViewSelector - Removed `selectionConfiguration.isSelectAll` from useEffect dependency array, likely as it's no longer needed which could prevent unnecessary re-renders or side effects. * [assistant_builder/vaults] - refactor: adjust margin for VaultSelector component - Removed top margin from the selectedVaultObj child component for a cleaner UI layout [front] - feature: update @dust-tt/sparkle to 0.2.269-rc-2 - Upgraded @dust-tt/sparkle, which includes new dependencies for @radix-ui/react-radio-group - Ensured compatibility with the new version and its additional dependencies for improved functionalities * [assistant_builder/vaults] - refactor: replace Checkbox with RadioGroup in VaultSelector - Transitioned from using Checkbox to RadioGroup for better UX in selecting vaults - Allowed for implementation of an onClick callback on disabled items and custom element rendering within labels - Ensured vault selection state and associated child components are updated accordingly * [front] - refactor: update RadioButton to RadioGroup component usage - Replace RadioButton component with the newer RadioGroup and RadioGroupChoice components for better structure and readability - Ensure RadioGroup's onValueChange handler uses strict equality for setting crawlMode value in VaultWebsiteModal - Update RadioButton to RadioGroup in CreateEnterpriseConnectionModal and Welcome page, including removing disabled choices as unnecessary - Modify EnterpriseConnectionDetails popup description text and email to provide updated contact information * [front] - fix: add unique keys to React.Fragment in VaultSelector - Ensure that each React.Fragment in the VaultSelector component has a unique key to prevent potential React key issues - Improve stability and performance of the VaultSelector's list rendering by using keys as recommended by React best practices * [front] - fix: update @dust-tt/sparkle to release version - Transitioned @dust-tt/sparkle dependency from release candidate to the official release version - Updated package-lock.json to ensure consistency with package.json dependency version --------- Co-authored-by: Jules <[email protected]> Co-authored-by: Jules <[email protected]> * [front] show unsupported directives (#8100) * [front] - fix: add z-index to AssistantBrowser to overlay dropdown menu (#8101) - Ensure that the new dropdown menu properly overlays other components by adjusting z-index - Add a TODO comment to remind of future replacement with popover component Co-authored-by: Jules <[email protected]> * [CacheWithRedis] Fix double unlock (#8102) Description --- Fixes an issue from #8077 related in this [thread](https://dust4ai.slack.com/archives/C05F84CFP0E/p1729249237889019) In some cases, lock was released twice (one in the finally, one outside it) Risks --- na Deploy --- connectors * [Assistant Browser] Adapt tab bar when searching (#8098) Description --- Following [thread](https://dust4ai.slack.com/archives/C050SM8NSPK/p1729238990143949): unclickable tabs were confusing when search was on. Initial solution was to hide tab bar. The PR goes for a similar solution with a slight difference, see gif Reasons were that hiding completely tab bar had been tested (see e.g. [here](#3655) ) and had following issues: - layout "jump" when typing in the search bar; - people not paying attention that something was typed in the search bar, and wondering where the tab bar was / why there were agents missing Technical: to ensure styles are kept exactly the same, "search" display is defined as another tab Risks --- na Deploy --- front * [front] enh: use latest gpt-4o model (#8088) * Add husky rule for npm run docs (#8096) * Add husky rule for npm run docs * Docs check strict validation * Make sure it runs only on front/ * Check format after npm docs check * Zendesk Connection Oauth UI behind FF (#7974) * Zendesk Connection Oauth UI behind FF * Lint * Use Zendesklogo * fix: mock connector initialization for zendesk * feat: add a ConfigurationModel for zendesk * misc: remove a TODO (to be reconsidered) --------- Co-authored-by: Aubin <[email protected]> * core: remove delete data source tx and batch documents deletion (#8104) * front: show dust incidents in UI (#8105) * [sparkle] - enh: `ScrollArea` (#8103) * [sparkle] - feature: implement custom ScrollArea component - Add a new `ScrollArea` component using `@radix-ui/react-scroll-area` primitives - Introduce a `ScrollBar` subcomponent for consistent scroll bar styling within `ScrollArea` * [sparkle] - feature: add ScrollArea component and update dependencies - Introduced `@radix-ui/react-scroll-area` package to provide a scrollable area component - Updated `csstype`, `nanoid`, `postcss`, `source-map-js`, and `tslib` dependencies to their latest versions - Created new `ScrollArea` component stories for documentation and usage examples - Minor styling adjustment for `ScrollAreaThumb` to use `s-bg-separator` classname - Included `ScrollArea` component in the main component exports for easier consumption - Updated `package.json` and `package-lock.json` to reflect new additions and updates * [sparkle] - feature: bump version to 0.2.270 - Increment package version to release new features or fixes - Ensure package-lock.json reflects the new version number for consistency * [sparkle] - feature: add scrollable popover example to stories - Implemented a new story to showcase a Popover with a ScrollArea containing a list of tags - Added capability to display a long list of items within a Popover, enhancing user interface flexibility --------- Co-authored-by: Jules <[email protected]> * [core] Allow empty role in content (#8106) * fix(doc tracker revival): pass workflow args in correct order (#8107) Co-authored-by: Henry Fontanier <[email protected]> * [connectors] Handle github bad credentials as transient errors (#8108) * [front] - fix: radix console logs first batch (#8112) * [front] - feature: update @dust-tt/sparkle package to v0.2.270 - Update the @dust-tt/sparkle package to include the latest features and bug fixes - Enhance dependency management by including @radix-ui/react-scroll-area and updating related packages within the node_modules - Align peer dependencies with broader React version support, including the upcoming version 19.0.0-rc * [front] - feature: add tooltipTriggerAsChild prop to tooltips for assistant creation and management - Ensure tooltips in AssistantBrowser are correctly associated with their child components for better accessibility and UX - Improve the user interface by making the tooltip appear as part of the trigger element for creating and managing assistants * [front] - refactor: standardize Popover trigger component usage - Added `popoverTriggerAsChild` prop to ensure Popover trigger is treated as a child component in various screens - Ensured `PopoverTrigger` in `Sharing.tsx` uses `asChild` prop for consistency with other components * [front/components/assistant_builder] - fix: adjust Popover usage for consistency - Remove unused 'popoverTriggerAsChild' prop from Popover component in InstructionScreen.tsx - Standardize PopoverTrigger usage in Sharing.tsx without passing 'asChild' prop * [front] - refactor: remove popoverTriggerAsChild prop from Popover component - Simplified Popover trigger configuration by removing unnecessary prop * [front] - feature: add popoverTriggerAsChild prop to EmojiSelector - Allows popover trigger element to be considered as a child for styling and layout purposes --------- Co-authored-by: Jules <[email protected]> * Vaults->Spaces step 2 (#8091) * Augment VaultResource constructor to support many groups * Add support for unrestricted vaults * ✨ * Restrict write to builder for unrestricted vault * ✨ * 👕 * 🙈 * 👕 * ✂️ * Address comments from review * ✨ * ✂️ * 👕 --------- Co-authored-by: Jules Belveze <[email protected]> Co-authored-by: Stanislas Polu <[email protected]> Co-authored-by: Alban Dumouilla <[email protected]> Co-authored-by: Thomas Draier <[email protected]> Co-authored-by: Philippe Rolet <[email protected]> Co-authored-by: Jules <[email protected]> Co-authored-by: Daphné Popin <[email protected]> Co-authored-by: Jules <[email protected]> Co-authored-by: Aubin <[email protected]> Co-authored-by: Henry Fontanier <[email protected]> Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/dust-tt/tasks/issues/1507
Show in the UI when we're having an incident. This will go a long way in making our users aware of ongoing issues.
Risk
It does not work.
Deploy Plan
front