[Assistant views] Remove 'assistant-search' & '{conversationId}' views #8109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
philipperolet
force-pushed
the
clean-views
branch
from
57d1643 to
13f4835
Compare
Description
---
- Removes 'assistant-search' view, which was actually exactly the same
as "list". The comment indicating inactive global agents were returned
was erroneous
- Removes '{conversationId}' view, since:
- it was actually only used in AssistantSuggestion, not anywhere else;
- the view didn't actually work, it was ~equivalent to list;
- the use case it was supposed to enable, viewing a shared
conversation with somebody else's personal assistant, is already
somewhat working: user can view conversation but not mention assistant
or see its details which is kind of fine.
We could aim in a follow-up PR to reinstate the conversation view
cleanly; that would require more work and is IMO not a priority.
Risks
---
Low, since it's just a view change. Tested locally. Regarding conversationId:
- handled all explicit calls
- looked for agentsGetView with potential implicit `agentsGetView: { conversationId }`: there are
- the internal api `asisstant/agent_configurations`, which is only called via swr's `useAgentConfigurations`
=> checked it does not use conversationId (since it also takes agentsGetView as param)
- the v1 api DustApi.getAgentsConfiguration call => here also, conversationId not used
Deploy
---
front
philipperolet
force-pushed
the
clean-views
branch
from
13f4835 to
003fa4b
Compare
philipperolet
added
the
documentation-ack
spolu
approved these changes
Oct 22, 2024
Done |
philipperolet
force-pushed
the
clean-views
branch
from
53377da to
c1210ca
Compare
philipperolet
force-pushed
the
clean-views
branch
from
c1210ca to
6b14597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes 'assistant-search' view, which was actually exactly the same as "list". The comment indicating inactive global agents were returned was erroneous
Removes '{conversationId}' view, since:
We could aim in a follow-up PR to reinstate the conversation view cleanly; that would require more work and is IMO low value and not a priority.
Risks
Low, since it's just a view change. Tested locally
Regarding the conversationId removal specifically:
conversationIdagentsGetView: { conversationId }: there areasisstant/agent_configurations, which is only called via swr'suseAgentConfigurations=> checked it does not use conversationId (since it also takes agentsGetView as param)
Deploy
front