-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socks5 proxy via dante #8145
Add socks5 proxy via dante #8145
Conversation
I'm a bit lost between nginx and dante and who uses what when and where. Do we have a design doc that describes the latest state? |
@@ -0,0 +1,24 @@ | |||
FROM alpine:3.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is special about our image? Ideally if we coule use a stock one we wouldn't need a github workflow etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one i used before was also very old and the creator was using « ash » (making it different from our others images, breaking k8s_ssh for example)
I’m not a fan of the extra workflow either but we shouldn’t have to run it often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok if there's no official image then LGTM 👍
|
||
EXPOSE 1080 | ||
|
||
ENTRYPOINT ["dumb-init"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the container to immediately shutdown.
Nginx = http proxy Norhing uses dante yet. The design doc is not up to date, i’ll update (btw i understood than design doc were only a point in time and they were not kept updated, is that incorrect ?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Well if the project is still ongoing it's good hygiene to have an up to date version so that it can be used to track progress and review to better understand PRs such as here. re nginx vs dante: I though it was possible to do with nginx? is it? Right now snowflake uses nginx then? what's the plan for dante? |
No problemo, will do
It is but turned out more hacky than i was expecting (running a client in front of nginx).
Yes
Immediately, nothing. Mostly about readiness for other db engines in « 48h » (such as postgres) |
ack thanks |
Description
This PR adds a SOCKS5 proxy using Dante. The changes include:
Usage:
Use the SOCKS_PROXY_HOST and SOCKS_PROXY_PORT env variables in
core
orconnectors
(already available).Risk
None
Deploy Plan
Apply infra