Biigint ftw wave 2 #9170
Merged
Biigint ftw wave 2 #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
commented
Dec 5, 2024
| autoIncrement: true, | ||
| primaryKey: true, | ||
| }, | ||
| connectorId: { |
There was a problem hiding this comment.
Not needed since we have a relationship defined below.
flvndvd
added
the
migration-ack
|
PMRR |
JulesBelveze
reviewed
Dec 6, 2024
| * A wrapper class that enforces BIGINT for all model primary keys. | ||
| * All models should extend this class instead of Sequelize's Model. | ||
| */ | ||
| export class BaseModel<M extends Model> extends Model< |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies the same logic as #9164 but for the connectors database.
All the tables have been migrated to BigInt in production.
Risk
Deploy Plan
No migrations required to be run.