Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Viz from being ill-used #9243

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Prevent Viz from being ill-used #9243

wants to merge 11 commits into from

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Dec 10, 2024

Description

Trying to fix Viz usage by Claude.
Claude is mistakenly using Viz to render slides.

Risk

Claude is not using Viz when it should.

@Duncid Duncid requested a review from spolu December 10, 2024 10:56
@Duncid Duncid changed the title Ed viz test Prevent Viz from being ill-used Dec 10, 2024
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 questions and a fix request otherwise the prompt looks directionally correct. happy to help moving it in the right place

@@ -83,6 +84,33 @@ export async function constructPromptMultiActions(

// INSTRUCTIONS section
let instructions = "INSTRUCTIONS:\n";

if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 quick questions:

  • I thought we wanted this for the global agent only?
  • We do have machinery for provider specific prompts so we should likely move it there right, also the prompt for visualization related stuff lives in visualization.ts so at the very least it should be moved there right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we wanted this for the global agent only?

Yes please it would be much preferable to have this on the global agent. The change would be here

instructions += `\
STOP AND CHECK BEFORE USING VISUALIZATION:\n
MANDATORY CHECKLIST - ALL MUST BE TRUE:\n
□ Contains actual data (numbers, measurements, statistics)\n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely want to use markdown notation here otherwise you're biasing the model toward giving up on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants