-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Viz from being ill-used #9243
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 questions and a fix request otherwise the prompt looks directionally correct. happy to help moving it in the right place
@@ -83,6 +84,33 @@ export async function constructPromptMultiActions( | |||
|
|||
// INSTRUCTIONS section | |||
let instructions = "INSTRUCTIONS:\n"; | |||
|
|||
if ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 quick questions:
- I thought we wanted this for the global agent only?
- We do have machinery for provider specific prompts so we should likely move it there right, also the prompt for visualization related stuff lives in
visualization.ts
so at the very least it should be moved there right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we wanted this for the global agent only?
Yes please it would be much preferable to have this on the global agent. The change would be here
instructions += `\ | ||
STOP AND CHECK BEFORE USING VISUALIZATION:\n | ||
MANDATORY CHECKLIST - ALL MUST BE TRUE:\n | ||
□ Contains actual data (numbers, measurements, statistics)\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely want to use markdown notation here otherwise you're biasing the model toward giving up on it.
Description
Trying to fix Viz usage by Claude.
Claude is mistakenly using Viz to render slides.
Risk
Claude is not using Viz when it should.